Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add TypeScript support #176

Closed
manovotny opened this issue Nov 8, 2021 · 1 comment
Closed

Add TypeScript support #176

manovotny opened this issue Nov 8, 2021 · 1 comment

Comments

@manovotny
Copy link
Owner

manovotny commented Nov 8, 2021

Will likely use @typescript-eslint/eslint-plugin.

A running list of things to consider too.

eslint/no-shadow

Disabled because of @typescript-eslint/no-shadow, if we choose to use it.

eslint/no-unused-expressions

Disabled because of @typescript-eslint/no-unused-expressions, if we choose to use it.

eslint/no-use-before-define

Disabled because of @typescript-eslint/no-use-before-define, if we choose to use it.

eslint/require-await

Disabled because of @typescript-eslint/require-await`, if we choose to use it.

eslint/spaced-comment

Settings needs to be changed to allow for TypeScript's triple-slash directives.

'spaced-comment': [
    'error',
    'always',
    {
        markers: ['/'],
    },
],

react/jsx-filename-extension

Settings need to be changed to allow TypeScript files.

Just need to enhance the existing rule in index.js.

if (usesTypeScript) {
    config.rules['react/jsx-filename-extension'][1].extensions.push('.tsx');
}
@manovotny
Copy link
Owner Author

This will fixed with the v7 release.

@manovotny manovotny mentioned this issue Jan 31, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant