Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrap default classifier into an abstract implementation #22

Closed
manthanhd opened this issue Nov 1, 2016 · 1 comment
Closed

Wrap default classifier into an abstract implementation #22

manthanhd opened this issue Nov 1, 2016 · 1 comment

Comments

@manthanhd
Copy link
Owner

This prepares for fully pluggable classifiers like Watson.

As of now, the following methods need to be exposed from the Classifier interface:

  • getClassifications(text, callback)
  • addDocument(text, topic, callback)
  • train(callback)

Most of these methods are currently synchronous so first of all that will have to change.

It would be a good idea to isolate the Classifier interface into its own package.

@manthanhd
Copy link
Owner Author

This abstract implementation might work with something like the talkify-watson-classifier.:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

No branches or pull requests

1 participant