Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

system remote commands via API should pass g_iMaxPacketSize #1155

Closed
tomatolog opened this issue Jun 1, 2023 · 1 comment
Closed

system remote commands via API should pass g_iMaxPacketSize #1155

tomatolog opened this issue Jun 1, 2023 · 1 comment

Comments

@tomatolog
Copy link
Contributor

tomatolog commented Jun 1, 2023

daemon has a check at the netreceive API bool bBadLength = ( iReplySize<0 || iReplySize>g_iMaxPacketSize ); that rejects incoming request in case it is larger than the server option max_allowed_packet

However some replication command could be large and it is hard at one node to get that option from the another node and split command into multiple packets then gather these packets at the remote node back into command.

It worth to skip bBadLength check for some SearchdCommand_e

@githubmanticore
Copy link
Contributor

➤ Stan commented:

should be fixed at 844b1ae and now max_packet_size should not affect internal replication command via API between nodes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants