Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tmp files left on failed optimize #1302

Closed
githubmanticore opened this issue Aug 1, 2023 · 3 comments
Closed

tmp files left on failed optimize #1302

githubmanticore opened this issue Aug 1, 2023 · 3 comments
Labels
bug rel::6.2.0

Comments

@githubmanticore
Copy link
Contributor

there are .tmp.spt files left and maybe sphi spm files too in case FinishMergeAttributes exists with error message like

rt common merge: table index_2: failed to merge indexes/index_2.264 (failed to create indexes/index_2.264.tmp.spt: No space left on device) 
rt common merge: table index_31: failed to merge indexes/index_31.286 (error writing .SPT)

seems #3035 already added code to clean up such tmp or orpath files but some of them are still left
@githubmanticore
Copy link
Contributor Author

➤ Stan commented:

fixed tmp files left after merge or optimize failed with errors at https://gitlab.com/manticoresearch/dev/-/commit/89eeb1ec437968b585c4973d16f5a717df8dbc80

@githubmanticore
Copy link
Contributor Author

➤ Stan commented:

now all tmp files should be removed (attribute related along with full-text related on any error at merge of indexes or optimize disk chunks)

@sanikolaev
Copy link
Collaborator

Fixed in 89eeb1e

@chenrui333 chenrui333 mentioned this issue Aug 4, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug rel::6.2.0
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sanikolaev @githubmanticore