Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

create distributed table set agent options from defaults #1424

Closed
tomatolog opened this issue Sep 5, 2023 · 1 comment
Closed

create distributed table set agent options from defaults #1424

tomatolog opened this issue Sep 5, 2023 · 1 comment
Assignees
Labels

Comments

@tomatolog
Copy link
Contributor

create statement create table d type='distributed' agent='127.0.0.1:9312:t' saves table description into manticore.json with values agent_connect_timeout and agent_query_timeout taken from the searchd options (defaults or user defined)

That is why after set other values at the searchd section will not affect distributed index and only way to change these options at the distributed index is to drop existed index and recreate it again.

@tomatolog
Copy link
Contributor Author

it could be better to hide assess of the agent_connect_timeout and agent_query_timeout at the AgentConn_t with the getters and keep the original value defined by the create table like

struct AgentConn_t
{
...
int GetConTimeout () const { return ( m_iMyConnectTimeoutMs<0 ? g_iAgentConnectTimeoutMs : m_iMyConnectTimeoutMs ); }

however at the time of the save of the manticore.json save the real values

@sanikolaev sanikolaev added the rel::upcoming Upcoming release label Sep 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants