Treating document IDs as numbers in /search responses

[Nick-S-2018]

Proposal:

Now, we pass document IDs as strings in HTTP responses from the /search endpoint . E.g., here is an example from our Manual:

POST /search
-d
'{
    "index" : "hn_small",
    "query":
    {
        "match":
        {
            "*" : "find joe"
        }
    },
    "_source": ["story_author","comment_author"],
    "limit": 1
}'


{
   "took" : 3,
   "timed_out" : false,
   "hits" : {
      "hits" : [
         {
            "_id" : "668018",
            "_score" : 3579,
            "_source" : {
               "story_author" : "IgorPartola",
               "comment_author" : "joe_the_user"
            }
         }
      ],
      "total" : 88063,
      "total_relation" : "eq"
   }
}

For the sake of consistency, we should pass IDs as numbers instead, just like we do for responses from other HTTP API endpoints. E.g., for the /replace we have:

POST /replace
-H "Content-Type: application/x-ndjson" -d '
{
  "index":"products",
  "id":1,
  "doc":
  {
    "title":"product one",
    "price":10
  }
}
'
{
  "_index":"products",
  "_id":1,
  "created":false,
  "result":"updated",
  "status":200
}

Checklist:

^{To be completed by the assignee. Check off tasks that have been completed or are not applicable.}

• Task estimated
• Specification created, reviewed and approved
• Implementation completed
• Tests developed
• Documentation updated
• Documentation proofread
• Changelog updated
• OpenAPI YAML updated and issue created to rebuild clients

[tomatolog]

fixed at the 0f2ecdf /search endpoint to output integers instead of string for id property

[sanikolaev]

@Nick-S-2018 pls update it in the docs

[sanikolaev]

@Nick-S-2018 pls also update the openapi yaml if required

[Nick-S-2018]

Updated docs. Openapi yaml doesn't need an update here.