Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FilterBadPulses should error if there is no proton_charge #10069

Closed
peterfpeterson opened this issue Mar 26, 2014 · 1 comment
Closed

FilterBadPulses should error if there is no proton_charge #10069

peterfpeterson opened this issue Mar 26, 2014 · 1 comment
Assignees
@peterfpeterson
Labels
Framework Issues and pull requests related to components in the Framework
Milestone
Release 3.2

Comments

@peterfpeterson
Copy link
Member

As this gets into a funny state that all events will be deleted when there isn't a proton charge, but the algorithm will return success. Do two checks:

  • Fail if "gd_prtn_chrg" is zero. If the log is missing skip the check and warn.
  • Fail if the maximum of "proton_charge" is zero.
@peterfpeterson
Copy link
Member Author

This issue was originally trac ticket 9226

@peterfpeterson peterfpeterson added the Framework Issues and pull requests related to components in the Framework label Jun 3, 2015
@peterfpeterson peterfpeterson self-assigned this Jun 3, 2015
@peterfpeterson peterfpeterson added this to the Release 3.2 milestone Jun 3, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@peterfpeterson peterfpeterson

Labels
Framework Issues and pull requests related to components in the Framework
Projects
None yet
Milestone
Release 3.2
Development

No branches or pull requests
1 participant
@peterfpeterson