Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Qmin, Qmax calculations in refl_gui #11059

Closed
OwenArnold opened this issue Sep 8, 2014 · 1 comment
Closed

Qmin, Qmax calculations in refl_gui #11059

OwenArnold opened this issue Sep 8, 2014 · 1 comment
Assignees
Labels
Reflectometry Issues and pull requests related to reflectometry
Milestone

Comments

@OwenArnold
Copy link
Contributor

This line:

https://github.com/mantidproject/mantid/blob/master/Code/Mantid/scripts/Interface/ui/reflectometer/refl_gui.py#L982

Is performing the same unit conversion defined for Momentum Transfer here : http://www.mantidproject.org/Unit_Factory

We are now very close to stripping all calculations out of the refl_gui. It would be good to create a temp SingleValue workspace for this
lambda value, and then run ConvertUnits rather than keeping the fragile calculation above. Ask Owen Arnold if this doesn't make sense. Be careful that you
can reproduce exactly the same result. You will need to do this sort of thing in the new gui anyway.

Need to ask about the following one. Create a separate ticket for this one when done with the above.

https://github.com/mantidproject/mantid/blob/master/Code/Mantid/scripts/Interface/ui/reflectometer/refl_gui.py#L757

@OwenArnold
Copy link
Contributor Author

This issue was originally trac ticket 10217

@OwenArnold OwenArnold added the Reflectometry Issues and pull requests related to reflectometry label Jun 3, 2015
@OwenArnold OwenArnold added this to the Release 3.3 milestone Jun 3, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Reflectometry Issues and pull requests related to reflectometry
Projects
None yet
Development

No branches or pull requests

2 participants