Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve SNS live listener behaviour when asking for start of run when we are not in a run #8630

Closed
1 task done
mantid-builder opened this issue Aug 20, 2013 · 1 comment
Closed
1 task done
Labels
Framework Issues and pull requests related to components in the Framework High Priority An issue or pull request that if not addressed is severe enough to postponse a release.
Milestone

Comments

@mantid-builder
Copy link
Collaborator

Original Reporter: Russell Taylor

This ticket is blocked by :

In http://trac.mantidproject.org/mantid/ticket/6661, we decided that if you ask for data from the start of the run when the instrument is not in a run, then the listener would just throw an exception, causing StartLiveData to fail. This is actually pretty unpleasant, especially when using the listener behind some interface other than the StartLiveData one. What would be better is if the listener just waited until a run did start, and then start passing back the events. The reason we didn't do this before is that we didn't want things to just lock up, potentially indefinitely, for the start of a run that never came - since the listener isn't able to check for a cancellation signal.

It has occurred to me that we could do this by creating a specific exception type and having the listener throw that in this situation (instead of throwing a general exception type, which just stops the algorithm). LoadLiveData could catch this exception, log it, check for cancellation and then call extractData() once again a few seconds later.


Keywords: LiveData

@mantid-builder
Copy link
Collaborator Author

This issue was originally trac ticket 7785

@mantid-builder mantid-builder added High Priority An issue or pull request that if not addressed is severe enough to postponse a release. Framework Issues and pull requests related to components in the Framework labels Jun 3, 2015
@mantid-builder mantid-builder added this to the Release 3.0 milestone Jun 3, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Framework Issues and pull requests related to components in the Framework High Priority An issue or pull request that if not addressed is severe enough to postponse a release.
Projects
None yet
Development

No branches or pull requests

1 participant