Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move the Muon workflow out of the MuonAnalysis interface code #9338

Closed
5 tasks done
mantid-builder opened this issue Nov 20, 2013 · 2 comments
Closed
5 tasks done

Move the Muon workflow out of the MuonAnalysis interface code #9338

mantid-builder opened this issue Nov 20, 2013 · 2 comments
Labels
Maintenance Unassigned issues to be addressed in the next maintenance period. Muon Issues and pull requests related to muons
Milestone

Comments

@mantid-builder
Copy link
Collaborator

Original Reporter: Arturs Bekasovs

This ticket is blocked by :

Muon Interface has quite a long sequence of things it does to the loaded workspace before it actually gets plotted on the screen. Currently, all these steps are buried in the depths of the interface code. This is bad.

Firstly, because it makes them difficult to test. Currently, only the individual algorithms are tested, but not how they are working together.

Secondly, this makes it impossible to use the workflow outside the interface, which is currently required for http://trac.mantidproject.org/mantid/ticket/6473.

To solve similar kinds of problems, a notion of ''Workflow algorithm'' was introduced. Those are not doing much work themselves, but are instead setting parameters for child algorithms. This seems like a right thing to use inside Muon Analysis.

So, the initial plan is:

  1. Find out how many and what kind of algorithms are needed.

  2. Write rigorous tests for them.

  3. Implement algorithms so that tests are passing.

  4. Refactor MuonAnalysis interface code to use these algorithms instead.

    Keywords: Maintenance

@mantid-builder
Copy link
Collaborator Author

This issue was originally trac ticket 8494

@mantid-builder
Copy link
Collaborator Author

http://trac.mantidproject.org/mantid/raw-attachment/ticket/8494/muon_workflow.png
muon_workflow.png
(uploaded by Arturs Bekasovs on 2014-02-25T14:52:54)


@mantid-builder mantid-builder added Muon Issues and pull requests related to muons Maintenance Unassigned issues to be addressed in the next maintenance period. labels Jun 3, 2015
@mantid-builder mantid-builder added this to the Release 3.2 milestone Jun 3, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Maintenance Unassigned issues to be addressed in the next maintenance period. Muon Issues and pull requests related to muons
Projects
None yet
Development

No branches or pull requests

1 participant