Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Amend WorkspaceProperty so that it can hold a pointer to a WorkspaceGroup #9616

Closed
mantid-builder opened this issue Jan 28, 2014 · 1 comment
Labels
Extra Attention Testers and Gate keepers should pay extra attention as this affects core aspects. Framework Issues and pull requests related to components in the Framework
Milestone

Comments

@mantid-builder
Copy link
Collaborator

Original Reporter: Russell Taylor

At present, WorkspaceProperty cannot generally hold or return the pointer to a WorkspaceGroup because it holds that pointer (in PropertyWithValue) as the WorkspaceProperty template type. This is usually MatrixWorkspace or a subtype, and WorkspaceGroup does not subclass MatrixWorkspace. Note that this template type also plays a role in validating input workspaces.

Because of this, in order to get hold of the pointer you have to go off to the ADS. This imposes a number of restrictions on us - for example, you can't pass a group to a sub-algorithm.

We need to find a way of holding a base Workspace pointer in a WorkspaceProperty. I think that ideally this should not change the interface of WorkspaceProperty, in particular the template type as this would impact just about every single algorithm.


Keywords: Core

@mantid-builder
Copy link
Collaborator Author

This issue was originally trac ticket 8772

@mantid-builder mantid-builder added Framework Issues and pull requests related to components in the Framework Extra Attention Testers and Gate keepers should pay extra attention as this affects core aspects. labels Jun 3, 2015
@mantid-builder mantid-builder added this to the Release 3.1 milestone Jun 3, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Extra Attention Testers and Gate keepers should pay extra attention as this affects core aspects. Framework Issues and pull requests related to components in the Framework
Projects
None yet
Development

No branches or pull requests

1 participant