Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix error in comparison operation in GenerateEventsFilter.cpp #9724

Closed
mantid-builder opened this issue Feb 4, 2014 · 1 comment
Closed

Fix error in comparison operation in GenerateEventsFilter.cpp #9724

mantid-builder opened this issue Feb 4, 2014 · 1 comment
Assignees
@wdzhou
Labels
Framework Issues and pull requests related to components in the Framework High Priority An issue or pull request that if not addressed is severe enough to postponse a release.
Milestone
Release 3.2

Comments

@mantid-builder
Copy link
Collaborator

Original Reporter: Russell Taylor

This ticket is blocks : TRAC8940

cppcheck has spotted the error at line 1166: Same expression on both sides of '<='.

Here's the code where in the second line an element of values is being compared to itself:

 else if ((i == 0) || (i >= 1 && ((filterIncrease && values[i] >= values[i-1]) ||
                                  (filterDecrease && values[i] <= values[i]))))
@mantid-builder
Copy link
Collaborator Author

This issue was originally trac ticket 8880

@mantid-builder mantid-builder added High Priority An issue or pull request that if not addressed is severe enough to postponse a release. Framework Issues and pull requests related to components in the Framework labels Jun 3, 2015
@mantid-builder mantid-builder added this to the Release 3.2 milestone Jun 3, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@wdzhou wdzhou

Labels
Framework Issues and pull requests related to components in the Framework High Priority An issue or pull request that if not addressed is severe enough to postponse a release.
Projects
None yet
Milestone
Release 3.2
Development

No branches or pull requests
2 participants
@wdzhou @mantid-builder