Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Logic error in refl gui #9880

Closed
OwenArnold opened this issue Feb 19, 2014 · 1 comment
Closed

Logic error in refl gui #9880

OwenArnold opened this issue Feb 19, 2014 · 1 comment
Labels
High Priority An issue or pull request that if not addressed is severe enough to postponse a release. Reflectometry Issues and pull requests related to reflectometry
Milestone
Release 3.1.1

Comments

@OwenArnold
Copy link
Contributor

The following is a bug introduced during last iteration's changes:

line 634 in refl_gui.py:

if isinstance(theta, numpy.float64):
        th = theta.size # This is wrong!
    elif not isinstance(theta, float):
        th = theta[len(theta) - 1]
    else:
        th = theta

The logic should be cleaned-up anyway.

Keywords: PatchCandidate
@OwenArnold
Copy link
Contributor Author

This issue was originally trac ticket 9037

@OwenArnold OwenArnold added High Priority An issue or pull request that if not addressed is severe enough to postponse a release. Reflectometry Issues and pull requests related to reflectometry labels Jun 3, 2015
@OwenArnold OwenArnold added this to the Release 3.1.1 milestone Jun 3, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
High Priority An issue or pull request that if not addressed is severe enough to postponse a release. Reflectometry Issues and pull requests related to reflectometry
Projects
None yet
Milestone
Release 3.1.1
Development

No branches or pull requests
1 participant
@OwenArnold