Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mantid Imaging - Rotating after cropping causes loss of data #1805

Closed
MialLewis opened this issue May 24, 2023 · 2 comments · Fixed by #1836 or #1852
Closed

Mantid Imaging - Rotating after cropping causes loss of data #1805

MialLewis opened this issue May 24, 2023 · 2 comments · Fixed by #1836 or #1852
Assignees

Comments

@MialLewis
Copy link

Summary

Raised by user Hamish_C https://forum.mantidproject.org/t/bug-mantid-imaging-rotating-after-cropping-causes-loss-of-data/857

Had a quick search of issues, doesn't look like this is a duplicate.

Steps To Reproduce

"Open an image in Mantid Imaging. Go to Workflow → Operations. Perform a crop to some non-square aspect ratio. Perform a 90 degree rotation."

Expected Behaviour

"When performing operations on a stack, if you choose to crop the stack to a non-square aspect ratio and then rotate the stack, you would expect that the “aspect ratio” also “rotates”, e.g. if you have a stack that has been cropped to have a width of 2 and a height of 1, and you rotate it by 90 degrees, you would expect the width to become 1 and the height to become 2, and all of the original data to still be represented."

Current Behaviour

"The aspect ratio of the final image (after rotation) is kept identical to before rotation, combined with a loss of data and addition of black bars to fill the space."

Context

"I am using this on IDAaaS at the moment, I believe the same happens in either the stable or unstable builds that are present on IDAaaS right now."

Screenshot(s)

image

@JackEAllen
Copy link
Collaborator

JackEAllen commented Jun 2, 2023

Snap aspect ratio to closest 90 degrees of rotation. If custom input of <=45 don't change aspect ratio, if custom input >=46 snap to 90 degrees etc.

@samtygier-stfc
Copy link
Collaborator

QComboBox to choose 90, 180, 270 or custom.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
3 participants