Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Misleading description for Container fluid prop #2175

Closed
jvllmr opened this issue Aug 19, 2022 · 2 comments · Fixed by #2179
Closed

Misleading description for Container fluid prop #2175

jvllmr opened this issue Aug 19, 2022 · 2 comments · Fixed by #2179

Comments

@jvllmr
Copy link
Contributor

jvllmr commented Aug 19, 2022

What package has an issue

@mantine/core

Describe the bug

/** If fluid is set to true, size prop is ignored and Container always take 100% of width */

"always take 100% of width" makes me think that the Container has the css prop width: 100%, but in reality it has max-width: 100%. It took me 10 minutes and the devtools to find out that it follows the second behaviour. :(

What version of @mantine/hooks page do you have in package.json?

^5.0

If possible, please include a link to a codesandbox with the reproduced problem

No response

Do you know how to fix the issue

Yes

Are you willing to participate in fixing this issue and create a pull request with the fix

Yes

Possible fix

Change description to If fluid is set to true, size prop is ignored and Container can expand to 100% of width or something similar (maybe reference the max-width prop as well)

@rtivital
Copy link
Member

Can you send a PR with a fix?

@jvllmr
Copy link
Contributor Author

jvllmr commented Aug 20, 2022

Of course, will create it asap

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants