Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MultiSelect placeholder does not respect primaryShade on error state #4111

Closed
Cuzart opened this issue Apr 21, 2023 · 1 comment · Fixed by #4113
Closed

MultiSelect placeholder does not respect primaryShade on error state #4111

Cuzart opened this issue Apr 21, 2023 · 1 comment · Fixed by #4113

Comments

@Cuzart
Copy link
Contributor

Cuzart commented Apr 21, 2023

What package has an issue

@mantine/core

Describe the bug

The MultiSelect component from @mantine/core does not respect the primaryShade set in theme.

MultiSelect.styles.ts
'&::placeholder': { opacity: 1, color: invalid ? theme.colors.red[theme.colorScheme === 'dark' ? 6 : 7] : theme.colorScheme === 'dark' ? theme.colors.dark[3] : theme.colors.gray[5], },

What version of @mantine/hooks page do you have in package.json?

6.0.8

If possible, please include a link to a codesandbox with the reproduced problem

https://codesandbox.io/s/nifty-diffie-jcq0xf?file=/src/App.tsx

Do you know how to fix the issue

Yes

Are you willing to participate in fixing this issue and create a pull request with the fix

Yes

Possible fix

Get the shade value dynamically from theme.fn.primaryShade( )

color: invalid ? theme.colors.red[theme.fn.primaryShade()]

@rtivital
Copy link
Member

You are welcome to submit a PR with a fix

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants