Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[@mantine/core] Spoiler: Avoid leaving a gap when label is null #5126

Merged
merged 1 commit into from Oct 26, 2023
Merged

[@mantine/core] Spoiler: Avoid leaving a gap when label is null #5126

merged 1 commit into from Oct 26, 2023

Conversation

sartak
Copy link
Contributor

@sartak sartak commented Oct 26, 2023

I'd like to use Spoiler just to reveal, not to hide again. However, passing hideLabel={null} leaves an unsightly gap below the Spoiler.

https://codesandbox.io/s/epic-waterfall-xkkzmv?file=/src/App.tsx

Spoiler leaves a gap when label is null

This PR fixes this issue by checking whether spoilerMoreContent is null.

@rtivital rtivital merged commit 72c0fcc into mantinedev:master Oct 26, 2023
1 check passed
@rtivital
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants