New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[@mantine/core] add non-empty check for portal className #5400

Merged

rtivital merged 1 commit into mantinedev:master from jvdsande:fix/portal-classname

Dec 10, 2023

Contributor

jvdsande commented Dec 9, 2023

As discussed on Discord, filter out the tokens passed to classList.add in modal to avoid the following DOM exception:

Uncaught DOMException: Failed to execute 'add' on 'DOMTokenList': The token provided must not be empty.

I added two non-regression tests regarding this.


          [@mantine/core] add non-empty check for portal className

bbe5260

rtivital merged commit 3fbe950 into mantinedev:master

1 check passed

Member

rtivital commented Dec 10, 2023

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment