Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[@mantine/core] Fixed Pagination autoContrast given by MantineProvider #5655

Closed
wants to merge 1 commit into from

Conversation

dswbx
Copy link

@dswbx dswbx commented Jan 27, 2024

The Pagination component's autoContrast worked when property is added to the component. But if the global autoContrast from theme object was given, it was ignored.

Worked:

<Pagination total={45} autoContrast />

Didn't work:

<MantineProvider theme={{ autoContrast: true }}>
  <Pagination total={45} />
</MantineProvider>

Also added a pagination story to show the case along with a button (which can be removed of course).

rtivital added a commit that referenced this pull request Jan 27, 2024
@rtivital
Copy link
Member

Thanks for reporting the issue! The fix that you've provided is not valid, I've implemented it differently. The fix will be available with the next patch.

@rtivital rtivital closed this Jan 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants