[@mantine/dates] Fix: minimum-date is not in current month and value is not provided #5786
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @rtivital, If this approach is good, then I will be checking for other date inputs and update those as well. Else, whatever the aproach is suggested, I will follow the same for every date inputs. |
rilrom
reviewed
Feb 22, 2024
| @@ -167,7 +167,7 @@ export const DateInput = factory<DateInputFactory>((_props, ref) => { | |||
|
|
|||
| useEffect(() => { | |||
| if (controlled) { | |||
| setDate(value!); | |||
| setDate(value ? value! : minDate!); | |||
There was a problem hiding this comment.
When clearable: true and you remove a selected value, visually it's removed from the UI however _date still gets set to the minDate instead of null.
|
Thanks for showing interest in contributing to Mantine! Unfortunately, this pull request cannot be accepted because of one of the following reasons:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5695.
This PR solves:
valueis null andminDateis in past or future, then this fix will takeminDateas default and show the calendar.