Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix switch accessibility #5746

Merged
merged 1 commit into from Feb 26, 2024
Merged

Conversation

rilrom
Copy link
Contributor

@rilrom rilrom commented Feb 9, 2024

Fixes #5699.

Things to note:

  • Due to the implementation of role="switch", some tests needed to be adjusted.
  • Screen readers no longer read out the onLabel and offLabel values, however I consider this to be appropriate as the label or aria-label should be used to provide enough context that these values are not needed.
  • Screen reader testing was conducted across macOS VoiceOver and Windows NVDA.
  • Open to suggestions on types for bodyElement and labelElement.

ocshawn

This comment was marked as resolved.

@rtivital rtivital merged commit da79556 into mantinedev:master Feb 26, 2024
1 check passed
@rtivital
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mantine Switch should follow accessibility best practices
3 participants