[@mantine/hooks] Fixed initial value of the online attribute returned by useNetwork()
#5766
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ed by `useNetwork()`
|
It is not a valid solution. It will produce a hydration mismatch if the hook value is used to render content in frameworks with ssr. |
[@mantine/hooks] Set the online status for environments without `navigator.connection` in `useNetwork()`
|
@rtivital you are right, I changed the code so the initial value is set in the |
|
Thanks! |
rtivital
pushed a commit
that referenced
this pull request
Feb 16, 2024
…ed by `useNetwork()` in Firefox (#5766) * [@mantine/hooks] Fixed initial value of the `online` attribute returned by `useNetwork()` * Update use-network.ts [@mantine/hooks] Set the online status for environments without `navigator.connection` in `useNetwork()`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #5765