Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

findDOMNode is deprecated in StrictMode #93

Closed
pimartin opened this issue May 22, 2021 · 2 comments
Closed

findDOMNode is deprecated in StrictMode #93

pimartin opened this issue May 22, 2021 · 2 comments
Projects

Comments

@pimartin
Copy link

Package: @mantine/core
Version: 1.2.1
Codesandbox: https://codesandbox.io/s/recursing-kepler-vzdm8?file=/src/App.js

Hi,
I have started using mantine and it works great, but when using React.StrictMode, a warning is printed in the console when a tooltip is triggered:

Warning: findDOMNode is deprecated in StrictMode. findDOMNode was passed an instance of Transition which is inside StrictMode. Instead, add a ref directly to the element you want to reference. Learn more about using refs safely here: https://reactjs.org/link/strict-mode-find-node

It appears to be linked to Transition (which I do not use directly in my code).

@rtivital
Copy link
Member

Thanks for reporting, this is known issue with react-transition-group – reactjs/react-transition-group#687

We need to implement new logic for ref usage as shown in 4.0.0 release

@rtivital rtivital added this to v1.2.0 release in Backlog May 23, 2021
@rtivital rtivital added help wanted Contributions from community are welcome and removed next minor labels Jul 5, 2021
@rtivital rtivital removed the help wanted Contributions from community are welcome label Aug 7, 2021
@rtivital
Copy link
Member

Fixed in 2.3.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Backlog
v1.3.0 release
Development

No branches or pull requests

2 participants