Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GitHub: should not try to create Webhook if secret has changed #357

Closed
dregad opened this issue Jan 23, 2021 · 0 comments
Closed

GitHub: should not try to create Webhook if secret has changed #357

dregad opened this issue Jan 23, 2021 · 0 comments
Labels
bug GitHub
Milestone
2.5.0

Comments

@dregad
Copy link
Member

dregad commented Jan 23, 2021

If the Webhook Secret field has been updated in the GUI but not saved in the DB, the Plugin should disable the Create Webhook button, as the code uses the stored value instead of the updated value and the created Webhook will have the old secret.
@dregad dregad added this to the 2.5.0 milestone Jan 23, 2021
@dregad dregad closed this as completed in cc83060 Jan 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug GitHub
Projects
None yet
Milestone
2.5.0
Development

No branches or pull requests
1 participant
@dregad