Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

checkin.php should not return HTTP/200 when operation fails #365

Closed
dregad opened this issue Apr 3, 2021 · 1 comment
Closed

checkin.php should not return HTTP/200 when operation fails #365

dregad opened this issue Apr 3, 2021 · 1 comment

Comments

@dregad
Copy link
Member

dregad commented Apr 3, 2021

Currently, when given an invalid payload, checkin.php informs caller about failure by displaying a standard MantisBT error page.

This is not easily processed in automated scenarios (e.g. webhooks), which are the normal usage of this page.

Page should return an appropriate HTTP 4xx error code in this case.

@dregad dregad added this to the 2.5.0 milestone Apr 3, 2021
@obmsch
Copy link
Contributor

obmsch commented Apr 8, 2021

@dregad It's not just the payload, but any error/exception in the current source plugin (#266). For me it's most
likely a windows (feature) update silently breaking my environment (SVN). I worked around it, by checking the
response (page) for any errors, in my post-commit hook.

@dregad dregad closed this as completed in c22e1d3 May 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants