Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Github: undefined array key warning when updating repo with empty client id/secret #383

Closed
dregad opened this issue Dec 30, 2021 · 0 comments
Closed

Github: undefined array key warning when updating repo with empty client id/secret #383

dregad opened this issue Dec 30, 2021 · 0 comments
Labels
bug GitHub
Milestone
2.5.0

Comments

@dregad
Copy link
Member

dregad commented Dec 30, 2021 •
edited

When updating a Github repo with empty client id/secret (i.e. after its initial creation, when mantis_plugin_Source_repository_table.info = 'a:0:{}'), PHP issues the following warnings:

SYSTEM WARNING: 'Undefined array key "hub_app_client_id"' in '.../plugins/source-integration/SourceGithub/SourceGithub.php' line 439
SYSTEM WARNING: 'Undefined array key "hub_app_secret"' in '/.../plugins/source-integration/SourceGithub/SourceGithub.php' line 440

Then depending on MantisBT display error settings, repo_update_page.php just dies there instead of properly redirecting.
@dregad dregad added this to the 2.5.0 milestone Dec 30, 2021
@dregad dregad closed this as completed in f47e9fe Dec 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug GitHub
Projects
None yet
Milestone
2.5.0
Development

No branches or pull requests
1 participant
@dregad