file_add(): Oracle BLOB contents must not be quoted

Using a quoted hex string causes error 'ORA-01465: invalid hex number for the query' when inserting the new record. Follow-up fix for issue #13227
mantisbt · Oct 16, 2013 · 02bbb99 · 02bbb99
1 parent 179916f
commit 02bbb99
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/core/database_api.php b/core/database_api.php
@@ -789,7 +789,7 @@ function db_prepare_binary_string( $p_string ) {
 			break;
 		case 'oci8':
 			$content = unpack( "H*hex", $p_string );
-			return '\'' . $content['hex'] . '\'';
+			return $content['hex'];
 		default:
 			return $p_string;
 			break;

diff --git a/core/file_api.php b/core/file_api.php
@@ -812,7 +812,7 @@ function file_add( $p_bug_id, $p_file, $p_table = 'bug', $p_title = '', $p_desc
 
 				chmod( $t_disk_file_name, config_get( 'attachments_file_permissions' ) );
 
-				$c_content = "''";
+				$c_content = '';
 			} else {
 				trigger_error( ERROR_FILE_DUPLICATE, ERROR );
 			}