Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lightweight Vs. Heavyweight #39

Closed
ghost opened this issue Nov 6, 2012 · 5 comments
Closed

Lightweight Vs. Heavyweight #39

ghost opened this issue Nov 6, 2012 · 5 comments

Comments

@ghost
Copy link

ghost commented Nov 6, 2012

Hey,

Would it be possible to remove the dependency on libextobjc (and therefore the dependency on both Configuration and libffi)?

For what is a relatively lightweight framework, including all these dependencies makes it much fatter. Since Mantle actually only depends on three .h/.m files from libextobjc and those themselves have no external dependencies, they could easily be rolled up into Mantle.

Please let me know your thoughts.

@jspahrsummers
Copy link
Member

Although you're correct that libffi is not used, the Configuration submodule is actually used to apply settings to Mantle itself.

When you say "fatter," what is your specific concern? What's the place affected by this choice where you would prefer something "lighter?"

@ghost
Copy link
Author

ghost commented Nov 6, 2012

So Configuration is used to apply settings to the Mantle project, rather than used by the framework itself?

My concern was simply about not adding unnecessary bloat to my project if I didn't need to.

Sent from my iPhone

On 6 Nov 2012, at 15:56, Justin Spahr-Summers notifications@github.com wrote:

Although you're correct that libffi is not used, the Configuration submodule is actually used to apply settings to Mantle itself.

When you say "fatter," what is your specific concern? What's the place affected by this choice where you would prefer something "lighter?"


Reply to this email directly or view it on GitHub.

@terinjokes
Copy link
Contributor

My understanding is with the Podspec, you're only including the few files from libextobjc that Mantle uses. Am I wrong?

@jspahrsummers
Copy link
Member

@micpringle But what bloat are you referring to? libffi and the unused bits of libextobjc aren't actually linked or copied into your project — they only exist in the git repository.

@jspahrsummers
Copy link
Member

Going to close this out, as I assume your concerns have been addressed. Feel free to reopen it if not.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants