Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

question: overwriting Base.symbols.dot #26

Open
boneskull opened this issue Mar 12, 2019 · 5 comments
Open

question: overwriting Base.symbols.dot #26

boneskull opened this issue Mar 12, 2019 · 5 comments

Comments

@boneskull
Copy link
Collaborator

Here: https://github.com/mantoni/mocaccino.js/blob/master/lib/setup-browser.js#L14

and here: https://github.com/mantoni/mocaccino.js/blob/master/lib/setup-node.js#L12

Mocaccino overwrites Base.symbols.dot. Why?

@mantoni
Copy link
Owner

mantoni commented Mar 12, 2019

Because IE 11 somehow managed to show an empty dot report with the mocha default character. I’d be happy to remove this if there’s a better option.

@boneskull
Copy link
Collaborator Author

That's probably better addressed by Mocha. But we don't test the dot reporter in the browser (until I started messing with it, anyway), so not surprised I'd never heard of this.

@mantoni
Copy link
Owner

mantoni commented Mar 12, 2019

I tried to find the original issue but no luck, also not in Mochify. It’s been like this for a long time. It might have been a PhantomJS related issue that’s completely obsolete. I can run some tests tomorrow.

@boneskull
Copy link
Collaborator Author

I can work around it for now by changing the value of dot in our tests. no rush.

@mantoni
Copy link
Owner

mantoni commented Mar 13, 2019

I ran some checks and cannot find any issues anymore. Works fine in IE 11 and Edge without overriding the symbol. Feel free to remove.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants