-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Depend on the phantomjs
module
#28
Comments
Hm, yeah, I thought about that. I use Mochify in a lot of small projects as a devDependency so that they are serving all the things you need (except for PhantomJS). So I like the idea generally. I'm a bit afraid of adding a dependency that is so large to something I install so frequently. It is already available in environments like Travis and also easy enough to install locally and you real only need one version of it. There is no need to nail down the PhantomJS version, I think. It feels a bit like adding all the gcc tools to your dependencies because you want to compile some c haha. Does that make any sense? |
It will only install a local copy if there's no global one or the global one is too old. I would want to make it as painless as possible for users to get started. Just being able to npm install mochify without having to do anything else would be nice for users. But I don't really care. I don't use this yet, just a suggestion from a lot of experience with creating tools ;) |
Oh nice, I didn't know! I'm already convinced :-) |
Instead of depending on the phantomjs module, I added a message stating this as an option. |
Can you please add this to the dependencies? It is really annoying, I tend to forget to install it and it is not really nice, to have deps in your package.json that are actually deps of a package and not your main project. |
The last time I checked, the npm dependency did not recognize my global install and would download the whole phantomjs thing on each fresh install. This is why I've decided to just print a message explaining what to do. |
So users don't have to install PhantomJS manually.
https://github.com/Medium/phantomjs
The text was updated successfully, but these errors were encountered: