Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use jquery npm instead of meteor/jquery #33

Open
sandervanhooft opened this issue Mar 16, 2016 · 4 comments
Open

use jquery npm instead of meteor/jquery #33

sandervanhooft opened this issue Mar 16, 2016 · 4 comments

Comments

@sandervanhooft
Copy link

Hi,

I'd suggest to include jQuery from npm instead of using the meteor package. I see it's now included by default in the meteor package list.

If I want to adhere to the 'pure' Mantra specs, I should now do:

import { Meteor } from 'meteor';
import { jQuery } from 'meteor/jquery';

I think the preferred Mantra way would be:

import { jQuery } from 'jquery';

I have not been able to test this yet. But I think this approach is much cleaner for isolated component development/testing.

Kind regards,

Sander

@TeemoWan
Copy link

+1

@TeemoWan
Copy link

when use storybook, it can't import jquery from 'meteor/jquery'

@makstr
Copy link
Contributor

makstr commented Apr 10, 2016

@sandervanhooft thanks, will update the import statement in the new version

@TeemoWan
Copy link

meteor/meteor#6626

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants