-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Collision Issue #39
Comments
Hi. Nice pictures! |
Can you upload the 2k dataset that crashes the fix collision function? (so that i can test it and see what can be done). |
Here is zip file of the json file with the data that crashes browser when attempting to create zoom level between 5 and 16. I can get it to render the page if i only put one zoom level but not really a solution considering the density of the points. |
Any feedback on the density of points when trying to calculate the collision positions |
Hi. Sorry for the delay but i think that i found the root of the problem. |
I've pushed a new |
I've added a demo with the 2k dataset here. |
@manubb no worries the areas where i had issues with small amounts of points rendering due to density of the points, now seems fixed when using the new circle.js file, they render all the points with out the browser crashing. It was always crash would only render once i reduced the number of points to around 500 7k points rendered at a position was previously crashing Thanks for your help my next option was cluster at the postgis database api and then only render one cluster point out for those areas that had issues |
The collision fix function was not designed to handle efficiently many points sharing same position. If you still have performance issue with the 477k dataset, you can consider doing some preprocessing to fix collisions on the same position clusters. |
Awesome work on this looks great when rendering out data points and has solved an issue with rendering 5k+ markers with leaflet. The issue im having is that im using the demo for the french cities as i like the way the markers are rendered, but when it comes to process collision on my datasets it is either crashing the browser or takes a very long time to calculate. And im assuming its the density of the points that is crashing my browser. As i have some datasets that its rendering 126k markers in about 33s but then i have a dataset of only 2k and the browser crashes during the quadtrees calculation. The largest dataset that i have passed through is 477K markers which actually renders the points but takes 12578s to complete the process. Any suggestions on how to improve the processing of these points faster or more efficiently. I want to continue to use the code in my application but struggling to find a solution to improve the processing of the points.
some examples of the results that im getting, though the first one did take some time to render (477K markers)
The text was updated successfully, but these errors were encountered: