Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

German spelling not correct #48

Closed
ReinholdH opened this issue Jan 5, 2022 · 3 comments
Closed

German spelling not correct #48

ReinholdH opened this issue Jan 5, 2022 · 3 comments

Comments

@ReinholdH
Copy link

The German bannerDescription in glowCookies.js is
'Wir nutzen Eigene und Cookies Dritter um Inhalte zu personalisieren und Surfverhalten zu analysieren.'
but the correct spelling has to be
'Wir nutzen eigene und Cookies Dritter, um Inhalte zu personalisieren und Surfverhalten zu analysieren.'
See: "eigene" instead of "Eigene" and the comma before "um"
@ueen
Copy link
Contributor

ueen commented Jan 6, 2022

Yea, would you mind opening a PR?

@scsskid
Copy link
Contributor

scsskid commented Jan 7, 2022

fixed the comma, added more well rounded translation
so also no need for discussion for how to spell "eigene" (some say its treated as a noun in this context, not a pronoun), nouns are capitalized German

PR: #49

@ReinholdH
Copy link
Author

Thanks. Perfect.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@scsskid @manucaralmo @ueen @ReinholdH