Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Error when using “Group” cv instances #28

Closed
aretor opened this issue Nov 13, 2021 · 1 comment
Closed

Error when using “Group” cv instances #28

aretor opened this issue Nov 13, 2021 · 1 comment

Comments

@aretor
Copy link
Contributor

aretor commented Nov 13, 2021

When Using a "Group" sklearn cross-validation object (in my case GroupShuffleSplit), the following error is raised

ValueError: The groups parameter should not be None

This issue might be related to #7646 of sklearn repo.

I managed to fix it by adding the groups parameter to the fit method, as done in other SearchCV algorithms (e.g. RandomizedSearchCV).

I can send a pull request if needed.
@manuel-calzolari
Copy link
Owner

Hi @aretor! Yes, pull requests are welcome

@aretor aretor mentioned this issue Nov 21, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@manuel-calzolari @aretor