Feature/youtube channel template #115
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Make sure you merge it withe develop!!! I have already updated it! |
lexbarba
reviewed
Apr 8, 2019
|
|
||
| </header> | ||
| <section class="subh"> | ||
| <div class="isubh"> |
There was a problem hiding this comment.
@Carlos7979 you have to look at BEM and rename all classes. BEM works as it follows:
A header could be:
header (block), header__title(block+element), header__img(block+element), header__quote(block+element), header__quote-link(block+element+element), header__quote-link--used (block+element+element+modifier). Please rename them using BEM.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is only the mobile version, when the screen size increases, the web change, but the desktop version is incomplete.