fix: throwing an error on invalid input

manuelbieh · May 24, 2019 · f5ff158 · f5ff158
1 parent c3b03b0
commit f5ff158
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 0 deletions.
diff --git a/src/getCoordinateKey.test.js b/src/getCoordinateKey.test.js
@@ -16,4 +16,11 @@ describe('getCoordinateKey', () => {
     it('should return an index of a GeoJSON array', () => {
         expect(getCoordinateKey([1, 2], ['latitude', 'lat', 0])).toEqual(0);
     });
+
+    it('should throw when an invalid coordinate is passed', () => {
+        expect(() => getCoordinateKey(null, ['latitude', 'lat', 0])).toThrow();
+        expect(() =>
+            getCoordinateKey(undefined, ['latitude', 'lat', 0])
+        ).toThrow();
+    });
 });
diff --git a/src/getCoordinateKey.ts b/src/getCoordinateKey.ts
@@ -7,6 +7,9 @@ const getCoordinateKey = <Keys>(
     return keysToLookup.reduce((foundKey: Keys | undefined, key: any):
         | Keys
         | undefined => {
+        if (typeof point === 'undefined' || point === null) {
+            throw new Error(`'${point}' is no valid coordinate.`);
+        }
         if (
             point.hasOwnProperty(key) &&
             typeof key !== 'undefined' &&