Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MGrid component's GetId function should call different property name, not Id. #10

Closed
theilgaz opened this issue Feb 17, 2021 · 1 comment
Closed

MGrid component's GetId function should call different property name, not Id. #10

theilgaz opened this issue Feb 17, 2021 · 1 comment

Comments

@theilgaz
Copy link

There are many developers using Id as an PK int. This is a common usage for relational database tables. I suggest you to change reserved Id property (as a Guid) to RowId or something like this.

In SQL Server there is a hidden row_id column for specifying unique line.
@manureini manureini reopened this Feb 17, 2021
@manureini
Copy link
Owner

Yes you are right. The usage of the id is not really a nice way in the grid.
I removed it in version 1.3.3. The Grid will now use the object itself instead the id to determine the selected row etc.
Can you test if these changes are working for you?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@manureini @theilgaz