add c++17 to build flags · manuvi/dpx@48d8e85 · GitHub

Commit

add c++17 to build flags

Browse files

Loading branch information

manuvi committed Mar 1, 2022

1 parent 30b9589 commit 48d8e85

configure.ac

-Original file line number
+Diff line change
@@ Expand Up / @@ -10,6 +10,7 @@ AC_CONFIG_MACRO_DIR([m4]) @@
     # Checks for programs.
     AC_PROG_CC
     AC_PROG_CXX
+    AX_CXX_COMPILE_STDCXX_17
     # libtool
     AM_DISABLE_SHARED
@@ Expand Down @@

5 comments on commit `48d8e85`

Randrianasulu commented on `48d8e85` Apr 4, 2022

can you provide rationale for this change?

Owner Author

manuvi commented on `48d8e85` Apr 4, 2022 via email

Hello Andrew, I guess this was for an object that I tried to insert but after some refactor I deleted. I'll drop this commit, you can avoid that. Thank you for your comment. Manuel Il giorno lun 4 apr 2022 alle ore 05:29 Andrew Randrianasulu < ***@***.***> ha scritto:

can you provide rationale for this change? — Reply to this email directly, view it on GitHub <48d8e85#commitcomment-70372749>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AO5AWY3NIXX5MZDB4R7CN33VDJO2ZANCNFSM5SOF2MCQ> . You are receiving this because you authored the thread.Message ID: <manuvi/dpx/commit/48d8e8532244aebddd1f3abe7f30efe83cbd61f5/70372749@ github.com>

Randrianasulu commented on `48d8e85` Apr 4, 2022 via email

On Monday, April 4, 2022, Manuel V ***@***.***> wrote: Hello Andrew, I guess this was for an object that I tried to insert but after some refactor I deleted. I'll drop this commit, you can avoid that. Thank you for your comment.

I also trying to incorporate your changes back into cingg, see https://lists.cinelerra-gg.org/pipermail/cin/2022-April/004877.html https://lists.cinelerra-gg.org/pipermail/cin/2022-April/004873.html + piles of other stuff

Manuel Il giorno lun 4 apr 2022 alle ore 05:29 Andrew Randrianasulu < ***@***.***> ha scritto: > can you provide rationale for this change? > > — > Reply to this email directly, view it on GitHub > <48d8e85 e83cbd61f5#commitcomment-70372749>, > or unsubscribe > <https://github.com/notifications/unsubscribe-auth/ AO5AWY3NIXX5MZDB4R7CN33VDJO2ZANCNFSM5SOF2MCQ> > . > You are receiving this because you authored the thread.Message ID: > <manuvi/dpx/commit/48d8e8532244aebddd1f3abe7f30efe83cbd61f5/70372749@ > github.com> > — Reply to this email directly, view it on GitHub <48d8e85#commitcomment-70381087>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AJSS7TNJ4U3BQ5O4FBK5MN3VDKFKJANCNFSM5SOF2MCQ> . You are receiving this because you commented.Message ID: <manuvi/dpx/commit/48d8e8532244aebddd1f3abe7f30efe83cbd61f5/70381087@ github.com>

Owner Author

manuvi commented on `48d8e85` Apr 5, 2022 via email

Hi Andrew, I read now all the conversation. You can't read dpx list because in the read sequence, FFmpeg wins. There are one ffmpeg at the top and one at the end the priority list. I don't know why ffmpeg said that dpxlist it's okay for him. However, if you change the priority order in the preferences, you should get the dpx file list. Really thank you for considering my patch. Manuel Il giorno lun 4 apr 2022 alle ore 15:04 Andrew Randrianasulu < ***@***.***> ha scritto:

On Monday, April 4, 2022, Manuel V ***@***.***> wrote: > Hello Andrew, > > I guess this was for an object that I tried to insert but after some > refactor I deleted. > I'll drop this commit, you can avoid that. > Thank you for your comment. I also trying to incorporate your changes back into cingg, see https://lists.cinelerra-gg.org/pipermail/cin/2022-April/004877.html https://lists.cinelerra-gg.org/pipermail/cin/2022-April/004873.html + piles of other stuff > > Manuel > > Il giorno lun 4 apr 2022 alle ore 05:29 Andrew Randrianasulu < > ***@***.***> ha scritto: > > > can you provide rationale for this change? > > > > — > > Reply to this email directly, view it on GitHub > > <48d8e85 > e83cbd61f5#commitcomment-70372749>, > > or unsubscribe > > <https://github.com/notifications/unsubscribe-auth/ > AO5AWY3NIXX5MZDB4R7CN33VDJO2ZANCNFSM5SOF2MCQ> > > . > > You are receiving this because you authored the thread.Message ID: > > <manuvi/dpx/commit/48d8e8532244aebddd1f3abe7f30efe83cbd61f5/70372749@ > > github.com> > > > > — > Reply to this email directly, view it on GitHub > < 48d8e85#commitcomment-70381087 >, > or unsubscribe > < https://github.com/notifications/unsubscribe-auth/AJSS7TNJ4U3BQ5O4FBK5MN3VDKFKJANCNFSM5SOF2MCQ > > . > You are receiving this because you commented.Message ID: > <manuvi/dpx/commit/48d8e8532244aebddd1f3abe7f30efe83cbd61f5/70381087@ > github.com> > — Reply to this email directly, view it on GitHub <48d8e85#commitcomment-70408105>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AO5AWY5LRT3PLWQVJALILRLVDLSE3ANCNFSM5SOF2MCQ> . You are receiving this because you authored the thread.Message ID: <manuvi/dpx/commit/48d8e8532244aebddd1f3abe7f30efe83cbd61f5/70408105@ github.com>

Randrianasulu commented on `48d8e85` Apr 5, 2022 via email

well, thank _you_ for writing suppirt in the firstvplace! now I tested latest cingg git + my patches and on older compiler (gcc 5.5.0) I need to add -std=c++11 to CFLAGS (or filedpx.C fails to compile) but otherwise it seems to work

On Tuesday, April 5, 2022, Manuel V ***@***.***> wrote: Hi Andrew, I read now all the conversation. You can't read dpx list because in the read sequence, FFmpeg wins. There are one ffmpeg at the top and one at the end the priority list. I don't know why ffmpeg said that dpxlist it's okay for him. However, if you change the priority order in the preferences, you should get the dpx file list. Really thank you for considering my patch. Manuel Il giorno lun 4 apr 2022 alle ore 15:04 Andrew Randrianasulu < ***@***.***> ha scritto: > On Monday, April 4, 2022, Manuel V ***@***.***> wrote: > > > Hello Andrew, > > > > I guess this was for an object that I tried to insert but after some > > refactor I deleted. > > I'll drop this commit, you can avoid that. > > Thank you for your comment. > > > > I also trying to incorporate your changes back into cingg, see > > https://lists.cinelerra-gg.org/pipermail/cin/2022-April/004877.html > > https://lists.cinelerra-gg.org/pipermail/cin/2022-April/004873.html > > + piles of other stuff > > > > > Manuel > > > > Il giorno lun 4 apr 2022 alle ore 05:29 Andrew Randrianasulu < > > ***@***.***> ha scritto: > > > > > can you provide rationale for this change? > > > > > > — > > > Reply to this email directly, view it on GitHub > > > <48d8e85 > > e83cbd61f5#commitcomment-70372749>, > > > or unsubscribe > > > <https://github.com/notifications/unsubscribe-auth/ > > AO5AWY3NIXX5MZDB4R7CN33VDJO2ZANCNFSM5SOF2MCQ> > > > . > > > You are receiving this because you authored the thread.Message ID: > > > <manuvi/dpx/commit/48d8e8532244aebddd1f3abe7f30ef e83cbd61f5/70372749@ > > > github.com> > > > > > > > — > > Reply to this email directly, view it on GitHub > > < > 48d8e85 e83cbd61f5#commitcomment-70381087 > >, > > or unsubscribe > > < > https://github.com/notifications/unsubscribe-auth/ AJSS7TNJ4U3BQ5O4FBK5MN3VDKFKJANCNFSM5SOF2MCQ > > > > . > > You are receiving this because you commented.Message ID: > > <manuvi/dpx/commit/48d8e8532244aebddd1f3abe7f30efe83cbd61f5/70381087@ > > github.com> > > > > — > Reply to this email directly, view it on GitHub > <48d8e85 e83cbd61f5#commitcomment-70408105>, > or unsubscribe > <https://github.com/notifications/unsubscribe-auth/ AO5AWY5LRT3PLWQVJALILRLVDLSE3ANCNFSM5SOF2MCQ> > . > You are receiving this because you authored the thread.Message ID: > <manuvi/dpx/commit/48d8e8532244aebddd1f3abe7f30efe83cbd61f5/70408105@ > github.com> > — Reply to this email directly, view it on GitHub <48d8e85#commitcomment-70486802>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AJSS7TLJZWLHCYXKZMKZGODVDPNUJANCNFSM5SOF2MCQ> . You are receiving this because you commented.Message ID: <manuvi/dpx/commit/48d8e8532244aebddd1f3abe7f30efe83cbd61f5/70486802@ github.com>

Please sign in to comment.