Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support for Gems specified by path #36

Closed
wants to merge 1 commit into from

Conversation

Mic92
Copy link
Member

@Mic92 Mic92 commented Oct 19, 2018

No description provided.

@Mic92
Copy link
Member Author

Mic92 commented Oct 19, 2018

@Mic92
Copy link
Member Author

Mic92 commented Oct 19, 2018

The weird thing is that I also need to set pname:

  with import <nixpkgs> {};

  bundlerEnv {
    pname = "serious";
    inherit ruby;
    gemdir = ./.;
  }

which is not exactly what I want. Because it will just take dependencies from pname then.
I currently try to get this project working: https://github.com/Binaergewitter/serious-bg

@zimbatm
Copy link
Member

zimbatm commented Oct 21, 2018

Nice! 👍 for the effort

What happens if the pname is not set? Did you try setting the name to bundler-env or something instead?

@Mic92
Copy link
Member Author

Mic92 commented Oct 21, 2018

I have not explained the reasoning behind this. It probably also works with name the same way.
The problem is that if a gem is loaded via path the source needs to be copied over: https://github.com/NixOS/nixpkgs/blob/master/pkgs/development/ruby-modules/bundled-common/default.nix#L66
This will only works at the moment if the gem is also the only gem in the project otherwise other dependencies in the project are ignored.

@zarelit
Copy link

zarelit commented Nov 27, 2018

I think this has been implemented in #37 that got merged two days ago

@Mic92
Copy link
Member Author

Mic92 commented Nov 27, 2018

yes.

@Mic92 Mic92 closed this Nov 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants