Skip to content
This repository has been archived by the owner on Jan 1, 2024. It is now read-only.

Passing a dictionary with configuration options to the direct renderer had no affect when using direct render. #98

Open
yoavaviram opened this issue Dec 17, 2020 · 3 comments
Labels
bug Something isn't working help wanted Extra attention is needed

Comments

@yoavaviram
Copy link

yoavaviram commented Dec 17, 2020

This does not work:

var mailgoConfig = {
  dark: true,
  details: {
    subject: false,
    body: false,
    to: false,
    cc: false,
    bcc: false,
  },
};
mailgoDirectRender(mailgoConfig, email);

While this does:

window.mailgoConfig = {
  dark: true,
  details: {
    subject: false,
    body: false,
    to: false,
    cc: false,
    bcc: false,
  },
};
mailgoDirectRender(email);
@manzinello
Copy link
Owner

Hi @yoavaviram, sorry but mailgoDirectRender doesn't support 2 parameters, it supports only the link at the moment, it is normal that if you call mailgoDirectRender(mailgoConfig, email); it doesn't work. Maybe I have written wrong it in docs? Check here https://mailgo.dev/docs/direct-render and here https://mailgo.dev/docs/mailgo-exports. Maybe are you suggesting a new implementation/enhancement of mailgoDirectRender? Thank you.

@manzinello
Copy link
Owner

If you are suggesting to add a new mailgoDirectRender I will change the title of this issue (and the tag). Please, let me know.

@manzinello
Copy link
Owner

I have made more test, it seems that there is something that is not working in the mailgoDirectRender with a window.config. Thank you so much for your messages, I have to work on this.

@manzinello manzinello added the bug Something isn't working label Dec 18, 2020
@manzinello manzinello added the help wanted Extra attention is needed label Mar 2, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants