Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issues with Node 8 and old node-sass #156

Closed
elclanrs opened this issue Dec 1, 2017 · 2 comments
Closed

Issues with Node 8 and old node-sass #156

elclanrs opened this issue Dec 1, 2017 · 2 comments
Assignees

Comments

@elclanrs
Copy link

elclanrs commented Dec 1, 2017

When installing in Node 8 with npm 5.5.1 it needs to compile node-sass@3.13.1 every time because this version didn't support Node 8 and the pre-compiled binary doesn't exist.

I looked into your package.json, and I could see why this version ic coming in through this package. Doing a search in node_modules after install node-sass-magic-importer gives me this:

λ find node_modules -type d -name 'node-sass'
node_modules/node-sass
node_modules/node-sass-selector-importer/node_modules/node-sass

If you inspect the node-sass bundled with node-sass-selector-importer it is version 3.13.1.

How is this package ending up there? How can we upgrade this package to the latest node-sass that works in Node 8 with pre-compiled binary?

@maoberlehner maoberlehner self-assigned this Dec 1, 2017
@maoberlehner
Copy link
Owner

maoberlehner commented Dec 1, 2017

Are you sure that you're using the latest release (5.x.x) of node-sass-magic-importer?

The 4.x.x release of this package had node-sass-selector-importer in version 4.x.x as a dependency, and the old 4.x.x release of node-sass-selector-importer had node-sass 3.13.1 as a dependency.

Please update node-sass-magic-importer to the latest 5.x.x release and everything should be fine.

Thank you for using node-sass-magic-importer.

@maoberlehner maoberlehner assigned elclanrs and unassigned maoberlehner Dec 1, 2017
@elclanrs
Copy link
Author

elclanrs commented Dec 1, 2017

Ah, thanks that was it!

@elclanrs elclanrs closed this as completed Dec 1, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants