Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

node-sass-once-importer does not create a new store per importer #189

Closed
ychailler opened this issue Mar 13, 2019 · 4 comments
Closed

node-sass-once-importer does not create a new store per importer #189

ychailler opened this issue Mar 13, 2019 · 4 comments
Assignees
Labels

Comments

@ychailler
Copy link

The context nodeSassOnceImporterContext created in each importer refers to the same store created in the contextTemplate object.
When using webpack-dev-server and the watch feature, the resulted file generated after the first code modification become empty as all imports are already stored in the store.

The behaviour is different from the node-sass-magic-importer where the store is created for each importer. In that case it works fine

@maoberlehner maoberlehner self-assigned this Mar 15, 2019
@maoberlehner
Copy link
Owner

Do I understand this correctly that node-sass-once-importer does not work but node-sass-magic-importer does work correctly?

@ychailler
Copy link
Author

no it is the opposite: it works with node-sass-magic-importer but not with node-sass-once-importer

@maoberlehner
Copy link
Owner

That's exactly what i wrote 😅

I'll take a look into it. Thanks for reporting.

@maoberlehner
Copy link
Owner

node-sass-once-importer@5.3.1 should work as expected. Thanks again for reporting this :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants