Skip to content
This repository has been archived by the owner on Oct 24, 2019. It is now read-only.

Prefix parameters with namespace #6

Closed
ianshward opened this issue Mar 22, 2016 · 2 comments
Closed

Prefix parameters with namespace #6

ianshward opened this issue Mar 22, 2016 · 2 comments

Comments

@ianshward
Copy link
Member

To avoid parameter name collisions, parameter names should be prefixed with the name of the rule.

@zmully
Copy link
Contributor

zmully commented Apr 14, 2016

So a couple of problems I've discovered with this. I don't think the rule parameters shouldn't know or care about their namespace, but when the parameters are namespaced this breaks the function.

Right now, I've got it namespacing the parameters during template generation, which is then fed to streambot in the format 'repositoryRulenameParametername'. When the function runs and Streambot sets its environment, the function is looking for 'Parametername' not 'repositoryRulenameParametername'.

Because the repository name is determined at runtime, I think that we could namespace the parameters by providing a helper function in lambda-cfn to generate the correct parameter names.

I haven't figured out exactly how the helper function would derive the correct parameter names though... so this may not be possible without changing the rule format.

@zmully
Copy link
Contributor

zmully commented Apr 21, 2016

fixed by #29

@zmully zmully closed this as completed Apr 21, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants