Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fantastic Features #175

Merged
merged 9 commits into from Jul 17, 2019
Merged

Fantastic Features #175

merged 9 commits into from Jul 17, 2019

Conversation

ingalls
Copy link
Contributor

@ingalls ingalls commented Jul 17, 2019

Context

  • Completely rework UI based error handling into a single error handling component
  • Move more UI API calls into the standard hecate library
  • Add support for loading the server schema at load time
  • Add support for displaying schema descriptions in the features panel

Screenshot from 2019-07-16 23-54-16

cc/ @ingalls

@ingalls ingalls self-assigned this Jul 17, 2019
@ingalls ingalls requested a review from a team July 17, 2019 03:55
@ingalls ingalls changed the title Feature descriptor Fantastic Features Jul 17, 2019
@ingalls
Copy link
Contributor Author

ingalls commented Jul 17, 2019

  • Add support for optionally loading the feature history into the UI

Screenshot from 2019-07-17 00-57-02

@ingalls
Copy link
Contributor Author

ingalls commented Jul 17, 2019

  • It's a bit rough around the edges, but display the loaded history

Screenshot from 2019-07-17 01-07-57

@ingalls
Copy link
Contributor Author

ingalls commented Jul 17, 2019

Closes: #54

@ingalls ingalls requested review from samely and removed request for a team July 17, 2019 14:08
samely
samely approved these changes Jul 17, 2019
View reviewed changes
Copy link

@samely samely left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🌮

@ingalls ingalls merged commit e083151 into master Jul 17, 2019
@ingalls ingalls deleted the feature_descriptor branch July 17, 2019 15:25
@ingalls ingalls mentioned this pull request Jul 19, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samely samely samely approved these changes

Assignees

@ingalls ingalls

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ingalls @samely