Changing MBVisualInstructionComponentType.image -> .icon

[JThramer]

Updating MBVisualInstructionComponentType to reflect new changes on API. This is to reflect that the icon component may have only text, and thus should be rendered as a generic route shield. Supports mapbox/mapbox-navigation-ios#1190.

/cc @mapbox/navigation-ios

[bsudekum]

@JThramer this looks like just the enum name is changing here, is that what you are going for?

[1ec5]

I’m not sure this change is strictly necessary. “Image” and “icon” are roughly synonymous in this context. We went with image for consistency with the VisualInstructionComponent.imageURL property, which is still present regardless of the API change.

[JThramer]

@bsudekum @1ec5 The idea here in my mind was that it was kinda silly to have a component type with the name of image if it may not actually contain an image.

[1ec5]

Hm, I guess I would make the same point about icon. I think type: icon in the API response should be seen as an indication that the component would be displayed as an image, whether or not that image comes from the API.

For context, this component type was originally conceived as a ref type for all road codes, but there was a consensus to move away from semantic types in favor of presentational types. Perhaps a future refactor could use subclasses instead of this enumeration to more clearly distinguish between the various kinds of components.

[JThramer]

Consensus was gained that this change is superfluous. Closing.