Decode polyline6 #281
Merged
Decode polyline6 #281
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frederoni
commented
Jun 21, 2018
MapboxDirections/MBRoute.swift
Outdated
| @@ -38,7 +38,8 @@ open class Route: DirectionsResult { | |||
| case let geometry as JSONDictionary: | |||
| coordinates = CLLocationCoordinate2D.coordinates(geoJSON: geometry) | |||
| case let geometry as String: | |||
| coordinates = decodePolyline(geometry, precision: 1e5)! | |||
| let precision = routeOptions.shapeFormat == .polyline ? 1e5 : 1e6 | |||
There was a problem hiding this comment.
Probably better to switch on routeOptions.shapeFormat?
There was a problem hiding this comment.
Yeah, probably. Although the line above, case let geometry as String: takes care of the case where it's geojson.
There was a problem hiding this comment.
We need to plumb this through MBRouteStep as well. 🤔
|
Ready for review |
bsudekum
approved these changes
Jun 25, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We're decoding a geometry string as
polylineeven if we specifypolyline6in the route options.@bsudekum @1ec5