Is siteOrigin required?

[davidtheclark]

This configuration property is used in two places currently:

• In prefixUrl.absolute(), if you use that.
• In sitemap generation.

Sitemaps won't work at all without it. Should it be required?

[davidtheclark]

We could skip sitemap generation and not provide prefixUrl.absolute if no siteOrigin is provided. That's another possibility.

[davidtheclark]

@jfurrow: I'm gonna hand this one to you so you have the opportunity to dig into Batfish a little bit.

[jfurrow]

I like the thought that users can still build their Batfish project without the siteOrigin property. I do think it would be useful to warn users of the implications (the implications being that no sitemap will be generated).

Maybe we could still create prefixUrl.absolute but throw an error if siteOrigin is undefined? This way the user will see a friendlier error message, rather than prefixUrl.absolute is not a function.

[davidtheclark]

Maybe we could still create prefixUrl.absolute but throw an error if siteOrigin is undefined? This way the user will see a friendlier error message, rather than prefixUrl.absolute is not a function.

@jfurrow: This sounds good to me. What do you think about sitemap generation?

[jfurrow]

@davidtheclark I think the build script could display a nice warning (maybe even with emojis and a link to the docs!) telling them that the sitemap was not generated.

[davidtheclark]

👍

[davidtheclark]

@jfurrow is this still on your radar, or should I pick it up today?

[jfurrow]

@davidtheclark Sorry for the delay, I'll make sure to complete this today!