Skip to content
This repository has been archived by the owner on Oct 24, 2019. It is now read-only.

PagerDuty serviceId passed in dispatch message body #48

Closed
zmully opened this issue Aug 28, 2017 · 3 comments
Closed

PagerDuty serviceId passed in dispatch message body #48

zmully opened this issue Aug 28, 2017 · 3 comments

Comments

@zmully
Copy link
Contributor

zmully commented Aug 28, 2017

Currently, the PagerDuty serivceId is configured as a stack parameter in dispatch-incoming and triage, but should be overrideable by the a serviceId in the Dispatch message.

For example, a self-service dispatch creates a PagerDuty incident if the user hits the "no" slack action. Right now that will always go to the service set by the stack parameter, but if the message were to look like:

body: { // required
        github: { ... },
        slack: { ... }, 
       pagerduty: {
            service: 'PDNCI9', //optional, defaults to stack parameter
            title: 'Something' //optional, defaults to github title
            body: 'Something' //optional, defaults to github body
       }
    }
@alulsh
Copy link
Member

alulsh commented Nov 3, 2017

@zmully - was this implemented? If so can we close this issue?

@k-mahoney k-mahoney added this to Future phase in Dispatch Roadmap Nov 9, 2017
@matiskay
Copy link
Contributor

It's not implemented yet. It will implemented soon https://github.com/mapbox/dispatch/issues/111.

@matiskay
Copy link
Contributor

pagerDutyServiceId variable was added in https://github.com/mapbox/dispatch/pull/112. Now, this variable is part of the spec.

Dispatch Roadmap automation moved this from Future phase to Complete Jan 17, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants