Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the stack name in the containerName #213

Closed
arunasank opened this issue Jun 10, 2018 · 0 comments · Fixed by #226
Closed

Use the stack name in the containerName #213

arunasank opened this issue Jun 10, 2018 · 0 comments · Fixed by #226

Comments

@arunasank
Copy link
Contributor

Currently, the containerName uses the options.service string, which is configured by the watchbot client. Since the string is not created using CloudFormation helper functions, the containerName cannot be customised based on the stack name. This means that if multiple stacks are running on the same service, the containerName reflects the service name and not the stack name and this can be confusing if you're parsing Cloudtrail logs and looking for containers of a specific stack.

To fix, we can change

{ Name: 'ContainerName', Value: prefixed('-worker-' + options.service) },
to concatenate using cloudfriend helper functions like Fn::Join

cc/ @mapbox/platform-engine-room

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant