Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More aggressively convert punctuation into fullwidth #3587

Open
1ec5 opened this issue Nov 10, 2016 · 0 comments
Open

More aggressively convert punctuation into fullwidth #3587

1ec5 opened this issue Nov 10, 2016 · 0 comments

Comments

@1ec5
Copy link
Contributor

1ec5 commented Nov 10, 2016

Following up from #3505 (comment) and #3438 (comment), we should replace certain non-CJK punctuation with their fullwidth equivalents more aggressively to avoid rotating them.

For example, 壹貳參(com) correctly becomes:

壹
貳
參
ᴒ͡
ᴑ
ᴟ
 ͝

but com(壹貳參) becomes:

ᴒ
ᴑ
ᴟ
壹͡
貳
參
︶

whereas it should be:

ᴒ
ᴑ
ᴟ
︵
壹
貳
參
︶

To get this right, we need to split verticalize_punctuation.lookup into three lookup tables (leftBinding, leftAndRightBinding, and rightBinding) and consider only the side(s) to which the character is naturally bound. So ( would be part of rightBinding because the character to the right is the only one that determines its ideographic-ness, whereas @ would be part of leftAndRightBinding because either adjacent character can make it non-ideographic.

/cc @lucaswoj @nickidlugash

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant